Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

landing strip reporter breaks in iTerm #211

Closed
tj opened this issue Jan 14, 2012 · 10 comments
Closed

landing strip reporter breaks in iTerm #211

tj opened this issue Jan 14, 2012 · 10 comments
Labels
type: bug a defect, confirmed by a maintainer

Comments

@tj
Copy link
Contributor

tj commented Jan 14, 2012

and possibly others
@adomokos
Copy link
Contributor

I have iTerm2 (Build 1.0.0.20120108). I tried this on mocha's own source code:

./bin/mocha -R landing

Worked fine.

@Couto
Copy link

Couto commented Jan 24, 2012

and I have iTerm2 (Build 1.0.0.20120123) and it's clearly broken…
Maybe has something to do about each user's settings…?

@adomokos
Copy link
Contributor

Upgraded iTerm2 to Build 1.0.0.20120123 and it still worked on mocha's source. I have no specific settings. What OS (OS X version) are you using?

@Couto
Copy link

Couto commented Jan 24, 2012

MacOSX 10.7.2

I forgot to mention that I use zsh as default shell prompt, although it still happens when i change to bash
not quite sure what else I can say, I believe i don't use any other weird setting beside the zsh instead of bash

@adomokos
Copy link
Contributor

I have the same version of OS and I use zsh as well.

Can you paste what you have in the terminal when you try running the specs with the landing reporter. Also could you run the specs on Mocha's own source code with the same command I used above.

@Couto
Copy link

Couto commented Jan 24, 2012

http://cl.ly/011p1k0q1P262f280m1T
http://cl.ly/2C3i2m271Z3b163W3G2D (the failed test is on purpose... no big deal there)

This is what I get normally...

using the same command that you did results in a "no such file" I installed mocha using npm -g so i guess the binary is somewhere else.

@davemckenna01
Copy link
Contributor

Landing works fine for me in iTerm 1 Build 0.10 and iTerm 2 Build 1.0.0 on 10.7.2

@shwaydogg
Copy link

Tested on Ubuntu 11.10's terminal and the landing strip only shows up once. (What is reported broken is that the strip is printed for each test, correct?)

If the terminal is full screen it looks perfect. However, if I decrease the width of the terminal screen then the command text is shown, partially cutoff, after the landing strip. Sounds like this is not what this issue is about though.

@tj
Copy link
Contributor Author

tj commented Jun 17, 2012

This issue has been inactive for over 1 month so I'm closing it. If you think it's still an issue re-open. - tjbot

@tj tj closed this as completed Jun 17, 2012
@dasilvacontin
Copy link
Contributor

Breaks in iTerm2 (Build 2.0) and in the last nightly (Build 2.9.20141006-nightly), on Mac OSX 10.10.

It works as intended on the default Terminal app.

@Couto Couto mentioned this issue Oct 10, 2014
Merged
travisjeffery pushed a commit that referenced this issue Oct 13, 2014
Merge pull request #1386 from dasilvacontin/master
97de6a1 
replaced non-ANSI.SYS escape sequence in landing reporter, fixes #211
boneskull pushed a commit to boneskull/mocha that referenced this issue Oct 17, 2014
Merge branch 'v2.0.0' of https://github.com/boneskull/mocha into over…
cc988ac 
…specified-async

# By Christopher Hiller (13) and others
# Via Christopher Hiller (7) and others
* 'v2.0.0' of https://github.com/boneskull/mocha: (45 commits)
  Remove 0.4 from .travis.yml
  Add 0.4 back to .travis.yml
  Release 1.21.5
  replaced non-ANSI.SYS escape sequence in landing reporter, fixes mochajs#211
  make project follow editorconfig rules
  add an .editorconfig
  fixing build for NodeJS v0.6.x
  refac(lib/*): add/remove semicolons, etc..
  refac(_mocha.js): remove duplicate declaration
  build
  do not attempt to highlight syntax when non-HTML reporter is used
  [reporter] Add test for pending tests of json-reporter
  Bumps escape-string-regexp to 1.0.2.
  HTML reporter: preserve query params when navigating to suites/tests
  utils.js: correcting botched indentation in canonicalize()
  .gitignore: ignore .patch and .diff files
  changed 'Catched' to 'Caught' in uncaught exception error handler messages
  [reporter] Add `pending` field for json reporter
  rm redundant var
  Runner.prototype.uncaught: don't double-end runnables that already have a state.
  ...
tandrewnichols pushed a commit to tandrewnichols/mocha that referenced this issue Dec 15, 2014
@dasilvacontin @tandrewnichols
replaced non-ANSI.SYS escape sequence in landing reporter, fixes moch…
4d0399f 
…ajs#211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tj @adomokos @Couto @davemckenna01 @dasilvacontin @shwaydogg