Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.lookupFiles test has too broad of an assertion #2347

Closed
boneskull opened this issue Jul 1, 2016 · 1 comment
Closed

utils.lookupFiles test has too broad of an assertion #2347

boneskull opened this issue Jul 1, 2016 · 1 comment
Assignees
@boneskull
Milestone
v3.0.0

Comments

@boneskull
Copy link
Member

Not sure how this happened, or what made those temp files, but:

  1) lookupFiles should not choke on symlinks:
     Error: expected [ '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/karma.conf_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/karma.conf_After_6f352fce4279ee1002338a0672d7c659e6b9e387.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/karma.conf_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/karma.conf_After_7efa3d9e30be1a19d22d03438ad79efdb0421ec0.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/karma.conf_After_96d9e06669262c395d74a12c2f15490535829507.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/karma.conf_After_9ac4a2d4799c05535966dbe43561384d33ce39f9.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/karma.conf_After_abaffa4e0efeeb0e05b6936dd3ed75fb625d264d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/karma.conf_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_context_After_b50aecc863f5de2af9a13d201a9cebaa66b4c9da.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_mocha_After_2975dc5ca9a0c6869a580c201f2698882b8b8b95.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_reporters_doc_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_reporters_html_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_reporters_json-cov_After_add08adb004cf249433c99c572f3dcf4d376f53d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_reporters_json-cov_After_e88d5910023ec0db794733866a58a9359a21da19.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_reporters_json-stream_After_add08adb004cf249433c99c572f3dcf4d376f53d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_reporters_json-stream_After_e88d5910023ec0db794733866a58a9359a21da19.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_runnable_After_b50aecc863f5de2af9a13d201a9cebaa66b4c9da.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_runnable_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_suite_After_2975dc5ca9a0c6869a580c201f2698882b8b8b95.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_utils_After_6f352fce4279ee1002338a0672d7c659e6b9e387.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_utils_After_7efa3d9e30be1a19d22d03438ad79efdb0421ec0.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_utils_After_9ac4a2d4799c05535966dbe43561384d33ce39f9.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_utils_After_b50aecc863f5de2af9a13d201a9cebaa66b4c9da.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/lib_utils_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/mocha-utils-link.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/mocha-utils.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/mocha_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_acceptance_fs_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_acceptance_lookup-files_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_acceptance_utils_After_6f352fce4279ee1002338a0672d7c659e6b9e387.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_acceptance_utils_After_9ac4a2d4799c05535966dbe43561384d33ce39f9.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_color_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_diffs_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_diffs_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_fixtures_hooks_multiple.hook.async.error_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_fixtures_hooks_multiple.hook.error_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_fixtures_pending_skip.async.beforeEach_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_fixtures_pending_skip.async.before_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_fixtures_pending_skip.async.spec_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_fixtures_regression_issue-1991_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_fixtures_regression_issue-1991_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_helpers_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_hook.err_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_hook.err_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_hook.err_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_hooks_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_hooks_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_hooks_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_multiple.done_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_multiple.done_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_pending_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_pending_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_pending_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_regression_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_regression_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_retries_After_8fe36a36c41aa22ceaa98fd86958d89c2b67fae5.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_timeout_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_timeout_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_uncaught_After_4af2b8d1ca4cae8ddafa89fa34018ebc0f7cb60d.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_integration_uncaught_After_78f36fcfd9f54c655e7621a6ae6741454ccaae39.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_runnable_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_utils_After_6f352fce4279ee1002338a0672d7c659e6b9e387.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_utils_After_9ac4a2d4799c05535966dbe43561384d33ce39f9.js',
  '/var/folders/7f/7vr9hv5j35zd_0k42n8m4xhw0000gs/T/test_utils_After_b9e96311b6ee73080ef51521496bbfeef4c3cb03.js' ] to have a length of 2 but got 64
      at Assertion.assert (node_modules/expect.js/index.js:96:13)
      at Assertion.length (node_modules/expect.js/index.js:345:10)
      at Context.<anonymous> (test/acceptance/lookup-files.js:35:8)
      at callFn (lib/runnable.js:330:21)
      at Test.Runnable.run (lib/runnable.js:323:7)
      at Runner.runTest (lib/runner.js:428:10)
      at lib/runner.js:534:12
      at next (lib/runner.js:348:14)
      at lib/runner.js:358:7
      at next (lib/runner.js:284:14)
      at lib/runner.js:321:7
      at done (lib/runnable.js:287:5)
      at callFn (lib/runnable.js:348:7)
      at Hook.Runnable.run (lib/runnable.js:323:7)
      at next (lib/runner.js:298:10)
      at Immediate._onImmediate (lib/runner.js:326:5)
@boneskull boneskull added status: accepting prs Mocha can use your help with this one! qa and removed status: accepting prs Mocha can use your help with this one! labels Jul 1, 2016
@boneskull boneskull self-assigned this Jul 3, 2016
@boneskull boneskull added this to the v3.0.0 milestone Jul 3, 2016
boneskull added a commit that referenced this issue Jul 3, 2016
@boneskull
fix wonky lookupFiles test; closes #2347
59b03a7
@boneskull
Copy link
Member Author

resolved in branch v3.0.0 via 59b03a7

boneskull added a commit that referenced this issue Aug 1, 2016
@boneskull
fix wonky lookupFiles test; closes #2347
cbf9bca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boneskull boneskull

Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@boneskull