Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow package-lock.json #3025

Closed
boneskull opened this issue Sep 28, 2017 · 1 comment
Closed

allow package-lock.json #3025

boneskull opened this issue Sep 28, 2017 · 1 comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc.

Comments

@boneskull
Copy link
Member

mainly for performance reasons. this will allow for better caching in CI, among other things.
@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. qa labels Sep 28, 2017
@boneskull boneskull added this to the v4.0.0 milestone Sep 28, 2017
@boneskull boneskull self-assigned this Sep 28, 2017
boneskull added a commit that referenced this issue Sep 28, 2017
@boneskull
introduce package-lock.json; closes #3025
47fe3ba 
- update `.travis.yml` to use npm@5 caching where available
- remove `.npmrc` (now unused)
- remove `package-lock.json` from `.gitignore`
@boneskull boneskull removed this from the v4.0.0 milestone Sep 28, 2017
@boneskull
Copy link
Member Author

this isn't gonna make it into v4.0.0 because there's some problems. for some reason nyc's deps aren't getting installed..?

@boneskull boneskull removed their assignment Sep 28, 2017
@boneskull boneskull added the status: accepting prs Mocha can use your help with this one! label Sep 28, 2017
@ScottFreeCode ScottFreeCode mentioned this issue Oct 3, 2017
Closed
1 task
@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Oct 4, 2017
boneskull added a commit that referenced this issue Dec 9, 2017
@boneskull
introduce package-lock.json; closes #3025
a11033b 
- update `.travis.yml` to use npm@5 caching where available
- remove `.npmrc` (now unused)
- remove `package-lock.json` from `.gitignore`
boneskull added a commit that referenced this issue Dec 9, 2017
@boneskull
introduce package-lock.json; closes #3025
e68d69e 
- update `.travis.yml` to use npm@5 caching where available
- remove `.npmrc` (now unused)
- remove `package-lock.json` from `.gitignore`
@renovate renovate bot mentioned this issue Feb 14, 2018
Merged
sgilroy pushed a commit to TwineHealth/mocha that referenced this issue Feb 27, 2019
@boneskull
introduce package-lock.json; closes mochajs#3025 (mochajs#3026)
6d3d908 
- update `.travis.yml` to use npm@5 caching where available
- remove `.npmrc` (now unused)
- remove `package-lock.json` from `.gitignore`
@snyk-bot snyk-bot mentioned this issue Jan 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boneskull