Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The growl code in _mocha is dead code (redux) #3341

Closed
plroebuck opened this issue Apr 21, 2018 · 4 comments
Closed

The growl code in _mocha is dead code (redux) #3341

plroebuck opened this issue Apr 21, 2018 · 4 comments

Comments

@plroebuck
Copy link
Contributor

Description

Remove growl-related dead code. Issue #2132 removed the unused growl() function, but the images used by that function remained.

plroebuck added a commit to plroebuck/mocha that referenced this issue Apr 21, 2018
Issue mochajs#2132 removed the unused growl() function, but left the images. This finishes the job.

Fixes mochajs#3341
@plroebuck
Copy link
Contributor Author

Removes the following dead code.

mocha/bin/_mocha

Lines 141 to 149 in 3a65a64

/**
* Images.
*/
const images = {
fail: path.join(__dirname, '..', 'assets', 'growl', 'error.png'),
pass: path.join(__dirname, '..', 'assets', 'growl', 'ok.png')
};

@boneskull
Copy link
Member

I would have expected ESLint to catch this. Hmmm...

@boneskull
Copy link
Member

derp, it's this at the top of the file:

/* eslint no-unused-vars: off */

boneskull added a commit that referenced this issue Apr 23, 2018
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@outsideris
Copy link
Member

closed by 55ebbdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants