Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable spinner in --watch. #806

Conversation

utkarshkukreti
Copy link

I'm unable to use node-foreman with --watch because of the spinner animation -

Screenshot with spinner:
Screen Shot 2013-04-11 at 8 51 15 PM

and without:
Screen Shot 2013-04-11 at 8 53 59 PM

Let me know if something needs to be changed.

@moll
Copy link

moll commented Apr 23, 2013

It seems to me the spinner gets in the way of reporting from the spec reporter as well.

@tj
Copy link
Contributor

tj commented Apr 24, 2013

I think I'd rather just remove it than start adding options for edge-cases. I don't use --watch personally so I'd hate to maintain another related option that I dont use

@utkarshkukreti
Copy link
Author

I'd say 👍 for removing it completely.

@utkarshkukreti
Copy link
Author

@visionmedia if you want a pull request for that, let me know!

@moll
Copy link

moll commented Apr 24, 2013

I'm all for having small cores, but I am curious, do you, @visionmedia, like, run tests by hand all the time? O_O

@tj
Copy link
Contributor

tj commented Apr 24, 2013

@moll yeah I'm in a terminal all day every day I have no problem running mt (make test) after writing some code

@utkarshkukreti
Copy link
Author

Wait, you are thinking of removing the spinner or --watch completely?

@tj
Copy link
Contributor

tj commented Apr 24, 2013

just the spinner, I know other people use --watch quite a bit

@ShijunK
Copy link

ShijunK commented Sep 17, 2013

+1 to remove the spinner
it works fine in terminal but causes problem running in Intellij IDEA's "Command Line Tools Console" where it prints endless "watching"
image

@pouriaMaleki
Copy link

+1 to remove the spinner

@sqs
Copy link

sqs commented Nov 23, 2013

+1 to remove the spinner. I find it distracting and manually edit it out of the .js source files when using mocha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants