Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't diff different object types #900

Closed
ghost opened this issue Jun 18, 2013 · 0 comments
Closed

Don't diff different object types #900

ghost opened this issue Jun 18, 2013 · 0 comments

Comments

@ghost
Copy link

ghost commented Jun 18, 2013

I have a function that returns '1-2-3' and expects [1, 2, 3]

The diff is really annoying to read, highlighting whitespace and commas and dashes. It's even more annoying with:

[ 2, null, 2 ] vs '2-2-3'

I suggest not showing diffs for differing types (arrays vs strings in this case)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants