Prefer process.stdout.write in xUnit reporter.
#1102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falls back to `console.log` if `process.stdout` is unavailable. Fixes mochajs#1068. (This also seems to have picked up a completely unrelated change to another file that hadn't yet made it into the mocha.js snapshot.)
|
@visionmedia Any comment on this? I believe this was affecting other people as well, so it seems it would be worth carrying the fix, unless you had a different approach in mind? |
|
@slashgrin it looks like #1106 also switches from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falls back to
console.logifprocess.stdoutis unavailable.This is another stab at fixing #1068 without breaking existing use cases. It works for me on my own ~1500 test suite in both Chrome and through mocha-phantomjs, and the Mocha self-tests pass.
I was having an issue with mocha-phantomjs not picking up the reporter output when used with the
--fileoptions because of the use ofconsole.log. Switching toprocess.stdout.write(when it is available) fixes the problem for me.This also seems to have picked up a completely unrelated change to another file that hadn't yet made it into the mocha.js snapshot. (See diff.) Is this sort of thing a regular occurrence?