Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Fix stackTraceFilter #2377

Closed
wants to merge 1 commit into from
Closed

Conversation

iakio
Copy link

@iakio iakio commented Jul 17, 2016

I found stackTraceFilter did not work on Windows.

C:\Users\ishida\src\test>node_modules\.bin\mocha --version
2.5.3

C:\Users\ishida\src\test>node_modules\.bin\mocha


  a
    1) b


  0 passing (21ms)
  1 failing

  1) a b:

      AssertionError: false == true
      + expected - actual

      -false
      +true

      at Context.<anonymous> (C:\Users\ishida\src\test\test\mytest.js:5:9)
      at callFn (C:\Users\ishida\src\test\node_modules\mocha\lib\runnable.js:326:21)
      at Test.Runnable.run (C:\Users\ishida\src\test\node_modules\mocha\lib\runnable.js:319:7)
      at Runner.runTest (C:\Users\ishida\src\test\node_modules\mocha\lib\runner.js:422:10)
      at C:\Users\ishida\src\test\node_modules\mocha\lib\runner.js:528:12
      at next (C:\Users\ishida\src\test\node_modules\mocha\lib\runner.js:342:14)
      at C:\Users\ishida\src\test\node_modules\mocha\lib\runner.js:352:7
      at next (C:\Users\ishida\src\test\node_modules\mocha\lib\runner.js:284:14)
      at Immediate._onImmediate (C:\Users\ishida\src\test\node_modules\mocha\lib\runner.js:320:5)

This patch will fix this:

C:\Users\ishida\src\test>node_modules\.bin\mocha


  a
    1) b


  0 passing (27ms)
  1 failing

  1) a b:

      AssertionError: false == true
      + expected - actual

      -false
      +true

      at Context.<anonymous> (test\mytest.js:5:9)

But this patch break some test. Please give me some advice.

stackTraceFilter did not work on Windows.
@boneskull boneskull added the status: needs review a maintainer should (re-)review this pull request label Sep 18, 2016
@boneskull boneskull self-assigned this Sep 18, 2016
@boneskull boneskull modified the milestone: v3.1.0 Sep 19, 2016
@boneskull
Copy link
Member

@iakio Thanks. I'm going to close this, but I can address this issue for you here quickly, I believe.

@boneskull boneskull closed this Sep 27, 2016
@boneskull boneskull removed the status: needs review a maintainer should (re-)review this pull request label Dec 12, 2017
@boneskull boneskull removed their assignment Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants