let child suites run if parent is exclusive; closes #2378 #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- includes some more refactoring of interface code into `lib/interfaces/common.js` for DRY (still more work to be done here) - unfortunately said refactoring contains hellish logic which addresses this issue (someone should make a flowchart of this for lolz) - original PR did not address `exports` interface; this doesn't either - may need more coverage against `qunit` interface
boneskull
added
the
status: waiting for author
| suite.pending = Boolean(opts.pending); | ||
| suite.file = opts.file; | ||
| suites.unshift(suite); | ||
| // I should be pilloried for the following. |
There was a problem hiding this comment.
The general idea is that we don't flip a bit on a Suite if something like describe.only() is used; instead we just reference its tests prop to onlyTests, so any tests in it (and within child Suites!) will be in the bucket.
If a Test would override this behavior, we destroy the reference. The behavior below depends on whether or not the parent still has the reference intact, which is confusing and bad.
If anyone wants to "adjust" this, feel free; it's in the issue/2387 branch.
|
retrying travis; seems to be transient sauce failure |
|
Guess I'll just merge this and publish another beta. |
boneskull
added a commit
that referenced
this pull request
Aug 1, 2016
- includes some more refactoring of interface code into `lib/interfaces/common.js` for DRY (still more work to be done here) - unfortunately said refactoring contains hellish logic which addresses this issue (someone should make a flowchart of this for lolz) - original PR did not address `exports` interface; this doesn't either - may need more coverage against `qunit` interface
helderroem
added a commit
to helderroem/mocha
that referenced
this pull request
Aug 7, 2016
* 'master' of github.com:mochajs/mocha: (79 commits) Release v3.0.1 update CHANGELOG.md; rebuild [ci skip] fix nested describe.only suites; closes mochajs#2406 update date in CHANGELOG.md [ci skip] Release v3.0.0 rebuild mocha.js fix bad merge of karma.conf.js add note about spec reporter to CHANGELOG.md [ci skip] fixed typo in mocha.css introduced by 185c0d9 [ci skip] Remove carriage return before each test line in spec reporter. Served no purpose add "logo" field to package.json [ci skip] fix incorrect executable name with new version of commander add bower.json to published package for npmcdn support [ci skip] fix broken/wrong URLs in CHANGELOG.md [ci skip] Release v3.0.0-2 rebuild mocha.js add browser-stdout to dependencies update CHANGELOG [ci skip] let child suites run if parent is exclusive; closes mochajs#2378 (mochajs#2387) Upgrade eslint package to 2.13 version (mochajs#2389) ...
boneskull
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/interfaces/common.jsfor DRY (still more work to be done here)exportsinterface; this doesn't eitherqunitinterfaceThis is a PR into the
v3.0.0branchcc @mochajs/core