fix uncaught TypeError if error occurs on next tick, closes #2315 #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
the
status: needs review
1999
force-pushed
the
fix/cannot-read-property-currentretry
branch
from
880bdd9
to
7a81a4f
Compare
|
Just merged from upstream/master + rebased |
|
Getting this merged and released would help avoid hundreds of flaky test failures in our codebase every day - any update on getting this in? |
|
@ljharb it'll go in the next release, assuming it's OK, but I need to review it. |
|
@1999 lgtm, thanks! |
boneskull
removed
the
status: needs review
|
ugh, n/m, let me look into this further. I'm so used to the appveyor failures being false alarms. |
boneskull
added
the
status: needs review
|
I'm not really convinced this is the "right" way to fix the issue, but after some experimentation it seems to have the least amount of friction. Main problem seems to be a flaky fixture which can evidently pass on Windows due to timing issues. I have an experimental change in 4e88243 with build here. If that has better results, I'll merge this and commit my change on top of it. |
1999
pushed a commit
to 1999/mocha
that referenced
this pull request
Sep 22, 2016
…-files-cache * upstream/master: attempt windows-friendly reproducible case for mochajs#2315 fix: fix uncaught TypeError if error occurs on next tick, closes mochajs#2315 (mochajs#2439) helpful error when necessary suite callback omitted; closes mochajs#1744 Fix an issue and add relevant tests when describe and xdescribe fail when not supplied with a callback (issue mochajs#1744). rename more fixtures; closes mochajs#2383 Report non-match to STDERR and exit if no files are matched (mochajs#2450) Exit process with correct error codes (mochajs#2445) fix test files not using .spec suffix fix test fixtures not using .fixture suffix always halt execution when async skip() called; closes mochajs#2465 (mochajs#2479) avoid test flake in "delay" test; closes mochajs#2469 (mochajs#2470) revert accidental change to bin paths disregard function names when testing under Node.js 6.5.0; closes mochajs#2467 (mochajs#2477) lints more files; add more files to lint check; closes mochajs#2457 adds *.orig to .gitignore Exclude the --inspect flag fix check-leaks to catch a leak whose name begins with 'd'
boneskull
removed
the
status: needs review
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.