Remove unused variables

[38elements]

Requirements

The escape argument for inlineDiff() and unifiedDiff() in Base.list() is always false.
inlineDiff() and unifiedDiff() are only used in Base.list() .
I think the escape argument is unnecessary.

mocha/lib/reporters/base.js

Lines 188 to 220 in 9f204ba

	var escape = true;
	if (index === -1) {
	msg = message;
	} else {
	index += message.length;
	msg = stack.slice(0, index);
	// remove msg from stack
	stack = stack.slice(index + 1);
	}
	// uncaught
	if (err.uncaught) {
	msg = 'Uncaught ' + msg;
	}
	// explicitly show diff
	if (err.showDiff !== false && sameType(actual, expected) && expected !== undefined) {
	escape = false;
	if (!(utils.isString(actual) && utils.isString(expected))) {
	err.actual = actual = utils.stringify(actual);
	err.expected = expected = utils.stringify(expected);
	}
	fmt = color('error title', ' %s) %s:\n%s') + color('error stack', '\n%s\n');
	var match = message.match(/^([^:]+): expected/);
	msg = '\n ' + color('error message', match ? match[1] : msg);
	if (exports.inlineDiffs) {
	msg += inlineDiff(err, escape);
	} else {
	msg += unifiedDiff(err, escape);
	}
	}

[coveralls]

Coverage increased (+0.07%) to 89.868% when pulling f8a26f1 on 38elements:patch-3 into 9f204ba on mochajs:master.

[boneskull]

Thanks!

Since errorDiff is only called with false for the escape value, why not just remove the parameter entirely and do this?

function errorDiff(err, type) {
  var actual = escapeInvisibles(err.actual);
  var expected = escapeInvisibles(err.expected);
  /* ... */
}

[boneskull]

good catch btw--it looks like this variable became useless somewhere around when inline diffs were added

[38elements]

Thank you for reviewing.
Since errorDiff() is only used in inlineDiff(), I removed not only escape but also type arguments.
The existing code is as follows.
Since Existing code uses err.actual and err.expected, I used err.actual and err.expected.

mocha/lib/reporters/base.js

Lines 447 to 459 in 9f204ba

	function errorDiff (err, type, escape) {
	var actual = escape ? escapeInvisibles(err.actual) : err.actual;
	var expected = escape ? escapeInvisibles(err.expected) : err.expected;
	return diff['diff' + type](actual, expected).map(function (str) {
	if (str.added) {
	return colorLines('diff added', str.value);
	}
	if (str.removed) {
	return colorLines('diff removed', str.value);
	}
	return str.value;
	}).join('');
	}

[coveralls]

Coverage increased (+0.06%) to 89.859% when pulling 6862867 on 38elements:patch-3 into 9f204ba on mochajs:master.

[coveralls]

Coverage increased (+0.1%) to 89.9% when pulling eee2fec on 38elements:patch-3 into 9f204ba on mochajs:master.

[boneskull]

@38elements thanks!