Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove play from bin/_mocha #3418

Merged
merged 2 commits into from Jun 20, 2018
Merged

remove play from bin/_mocha #3418

merged 2 commits into from Jun 20, 2018

Conversation

Bamieh
Copy link
Contributor

@Bamieh Bamieh commented Jun 18, 2018

I dont see this function used anywhere, also stop now just spits \u001b[2K to the stdout for the rerun, I am not sure if it is needed as well.

bin/_mocha Outdated
const str = arr[i++ % len];
process.stdout.write(`\u001b[0G${str}`);
}, interval);
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two blank lines. So, linting is failed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.018% when pulling 34b2577 on remove-play into eeccd05 on master.

Copy link
Member

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh
Copy link
Contributor Author

Bamieh commented Jun 19, 2018

@outsideris do you have any idea what \u001b[2K does? i know is unicode but im unable to figure it out.

@outsideris
Copy link
Member

@Bamieh
I didn't know about that.

As SO, \u001b means ESC.
As ANSI Escape sequences, Esc[2K means Clear entire line.

@Bamieh Bamieh merged commit babd958 into master Jun 20, 2018
@Bamieh Bamieh deleted the remove-play branch November 18, 2018 18:17
@boneskull boneskull added this to the v6.0.0 milestone Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants