Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable CI uncaughtException test #4107

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Fix unstable CI uncaughtException test #4107

merged 1 commit into from
Nov 26, 2019

Conversation

juergba
Copy link
Member

@juergba juergba commented Nov 25, 2019

Description

One of our CI tests is unstable and fails occasionally.

  • it should fail while the runner is still active which resulted in an exitCode of 2 (number of failing tests).
  • sometimes it fails too late, after the EVENT_RUN_END event when all tests have finished. Then it is caught by the uncaughtException handler and exits with exitCode of 7.

Since 2 (expected) !== 7 (actual) ==> the test fails.

Description of Change

We use process.nextTick() instead of setTimeout().

related #4103

@juergba juergba added type: bug a defect, confirmed by a maintainer qa labels Nov 25, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.723% when pulling b1f5a69 on juergba/stable-CI into 2e816fe on master.

@juergba juergba merged commit 47dcc5f into master Nov 26, 2019
@juergba juergba deleted the juergba/stable-CI branch November 26, 2019 17:26
@juergba juergba added this to the v7.0.0 milestone Nov 26, 2019
@juergba juergba added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants