Mark HTTP 429 responses as allowed failures in hyperlink check #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metimes get these from unpkg and it shouldnt block out builds
Munter
added
type: chore
craigtaub
approved these changes
Apr 25, 2020
juergba
approved these changes
Apr 26, 2020
boneskull
pushed a commit
that referenced
this pull request
Apr 29, 2020
…metimes get these from unpkg and it shouldnt block out builds (#4253)
craigtaub
added
the
semver-patch
craigtaub
pushed a commit
that referenced
this pull request
May 21, 2020
…metimes get these from unpkg and it shouldnt block out builds (#4253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes get HTTP 429 responses from unpkg.com when checking the links to mocha and chai assets we use in a cope/pasteable code reference for how to run mocha in a browser.
These checks should still run, but if we know that we might get HTTP 429 because unpkg is temporarily overloaded we should not fail the build.
Example of such a failure: https://app.netlify.com/sites/mocha/deploys/5ea2e0db7751000007185cf1
Adding a
--todomatch on the error we get in hyperlink allows that particular response to fail without failing the build