Add missing commit in v8.0.0 release #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsideris
changed the title
juergba
reviewed
Jun 17, 2020
juergba
reviewed
Jun 17, 2020
There was a problem hiding this comment.
Maybe you should also change, as shown in package.json:
Mocha v8.0.0 now requires Node.js v10.0.0 or newer. => 10.12.0 or newer.
To change the GH release you have to copy/paste your changes manually.
outsideris
force-pushed
the
update-8.0.0-changlog
branch
from
d1b7ed2
to
649ff83
Compare
|
I moved the commit under "Others" I will update release notes after merging this. |
juergba
approved these changes
Jun 21, 2020
There was a problem hiding this comment.
@outsideris you haven't updated the version to >= v10.12.0, otherwise looks LGTM.
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
force-pushed
the
update-8.0.0-changlog
branch
from
649ff83
to
e81a7be
Compare
|
Updated |
|
Updated v8.0.0 release note as well. |
boneskull
added
the
semver-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commit was missed in v8.0.0 changelog. See v7.2.0...v8.0.0.