Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle errors in supporter images during 11ty build #4357

Merged
merged 1 commit into from Jul 30, 2020
Merged

handle errors in supporter images during 11ty build #4357

merged 1 commit into from Jul 30, 2020

Conversation

boneskull
Copy link
Member

@boneskull boneskull commented Jul 1, 2020 •
edited

  • canvas now checks for errors and discards supporters, which will avoid problems during postbuild step
  • output debug info in build
  • remove image-size in lieu of canvas which is now a direct dev dependency

@boneskull boneskull added the area: website involving mochajs.org, but not necessarily involving docs label Jul 1, 2020
@boneskull boneskull self-assigned this Jul 1, 2020
@coveralls
Copy link

coveralls commented Jul 1, 2020 •
edited

Coverage Status

Coverage remained the same at 93.766% when pulling e68099d on boneskull/fix-netlify-images into 7540efb on master.

@boneskull boneskull force-pushed the boneskull/fix-netlify-images branch from 3bd9d5b to cb566b8 Compare July 1, 2020 21:41
@boneskull boneskull marked this pull request as ready for review July 1, 2020 21:41
@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Jul 1, 2020
@boneskull boneskull force-pushed the boneskull/fix-netlify-images branch from cb566b8 to e68099d Compare July 1, 2020 21:52
@boneskull boneskull changed the title attempting to fix netlify problems handle errors in supporter images during 11ty build Jul 1, 2020
@boneskull boneskull mentioned this pull request Jul 7, 2020
Closed
outsideris
outsideris approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for conflict.

@boneskull
handle errors in supporter images during 11ty build
b97e9ba 
- `canvas` now checks for errors and discards supporters, which will avoid problems during postbuild step
- output debug info in build
- remove `image-size` in lieu of `canvas` which is now a direct dev dependency
@boneskull boneskull force-pushed the boneskull/fix-netlify-images branch from e68099d to b97e9ba Compare July 13, 2020 19:31
@boneskull boneskull merged commit cf736fe into master Jul 30, 2020
@boneskull boneskull deleted the boneskull/fix-netlify-images branch July 30, 2020 18:50
@boneskull boneskull added this to the next milestone Jul 30, 2020
@juergba juergba mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees

@boneskull boneskull

Labels
area: website involving mochajs.org, but not necessarily involving docs semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boneskull @coveralls @outsideris