Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove caching growl step #4546

Closed
wants to merge 2 commits into from
Closed

Remove caching growl step #4546

wants to merge 2 commits into from

Conversation

outsideris
Copy link
Member

@outsideris outsideris commented Jan 8, 2021 •
edited

Removed caching Growl on Windows.

It has suddenly broken because it restored from an empty cache.
We don't know why, but we should find an alternative instead of Growl because Growl is retired.

And preventing to trigger GitHub Action twice by maintainers.

@outsideris
remove caching growl step
23973af 
cache will be restored in previous Cache Growl Installer step

Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris outsideris changed the title remove caching growl step Remove caching growl step Jan 8, 2021
@outsideris outsideris self-assigned this Jan 8, 2021
@outsideris outsideris added the type: chore generally involving deps, tooling, configuration, etc. label Jan 8, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.143% when pulling 23973af on outsider-action-growl into c21a90f on master.

@outsideris
prevent to trigger GH action twice
d345ca1 
When maintainers push a branch on mocha repo
and then open a PR from it,
two GH actions will be triggered by both push and
pull_request events.

Signed-off-by: Outsider <outsideris@gmail.com>
@juergba
Copy link
Member

juergba commented Jan 9, 2021

@outsideris There are two exceptions about missing *.dll files in the Start Growl Service jobs.
What do you think about those?

@juergba juergba added area: repository tooling concerning ease of contribution qa labels Jan 9, 2021
@outsideris
Copy link
Member Author

They are known exceptions, but I don't know why exactly.

@juergba
Copy link
Member

juergba commented Jan 10, 2021

On my branch this solution failed again.

Run echo "Starting Growl service..."
Starting Growl service...
Verifying Growl responding
Notification failed: 201 - The destination server was not reachable
Notification failed: 201 - The request failed to be sent successfully due to a network problem.

Notification failed: 201 - The response failed to be read successfully due to a network problem.
Notification failed: 201 - The destination server was not reachable
Notification failed: 201 - The request failed to be sent successfully due to a network problem.
Notification failed: 201 - The response failed to be read successfully due to a network problem.
System.DllNotFoundException: Unable to load DLL 'dnssd.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
   at Mono.Zeroconf.Providers.Bonjour.Native.DNSServiceCreateConnection(ServiceRef& sdRef)
   at Mono.Zeroconf.Providers.Bonjour.Zeroconf.Initialize()
   at Mono.Zeroconf.Providers.Bonjour.ZeroconfProvider.Initialize()
   at Mono.Zeroconf.Providers.ProviderFactory.GetProviders()
System.DllNotFoundException: Unable to load DLL 'dnssd.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
   at Mono.Zeroconf.Providers.Bonjour.Native.DNSServiceCreateConnection(ServiceRef& sdRef)
   at Mono.Zeroconf.Providers.Bonjour.Zeroconf.Initialize()
   at Mono.Zeroconf.Providers.Bonjour.ZeroconfProvider.Initialize()
   at Mono.Zeroconf.Providers.ProviderFactory.GetProviders()
Error: Process completed with exit code 1.

I'm sick of this Growl hassle.

@juergba
Copy link
Member

juergba commented Jan 10, 2021

Is it possible to keep the workflow going inspite of a failing growl test?

@outsideris
Copy link
Member Author

We don't need this because of https://github.com/mochajs/mocha/pull/4547/files .
I will try to test that we can replace growl.

@outsideris outsideris closed this Jan 19, 2021
@juergba juergba deleted the outsider-action-growl branch April 17, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@outsideris outsideris

Labels
area: repository tooling concerning ease of contribution type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@outsideris @coveralls @juergba