Export top-level suite on global mocha object (mocha.suite). Closes #448 #458
Conversation
|
@visionmedia do you think you can merge this even without a test? It would be covered by the Konacha test suite, so if anything breaks in the future, we'll find out pretty quickly. |
|
what's the need to expose it? (just curious) |
|
See #448. We'd like Konacha to work with every interface. For that it needs to have a way to set up its own beforeEach callback, regardless of the interface that's been activated. |
…ochajs#448 This should probably be tested, since it's an API that we'll rely on in Konacha, but I'm not sure what's the best way to do so.
|
sounds reasonable. I would like if we could do similar on the node-side of things since it's a bit inconsistent to do one but im cool with this for now |
Export top-level suite on global mocha object (mocha.suite). Closes #448
Oh, I hadn't realized this wouldn't work on Node. Having it on Node as well would definitely be reasonable. Anyways, I'll go use this with Konacha now. By the way, if you need to change the API later so it works with Node as well, don't worry about breaking compatibility for us (as long as it doesn't go away entirely) -- we'll just update our code as Mocha changes. |
This should probably be tested, since it's an API that we'll rely on in
Konacha, but I'm not sure what's the best way to do so.