Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: remove 'cross-spawn' #4779

Merged
merged 1 commit into from Oct 29, 2021
Merged

devDeps: remove 'cross-spawn' #4779

merged 1 commit into from Oct 29, 2021

Conversation

juergba
Copy link
Member

@juergba juergba commented Oct 26, 2021

Description

We use cross-spawn in our integration tests only.
We remove it from our devDependencies and use Node's native child-process module instead, which has been stable for many years now.

@juergba juergba added chore semver-patch node.js dependencies labels Oct 26, 2021
@juergba juergba self-assigned this Oct 26, 2021
@juergba juergba requested a review from Oct 26, 2021
nicojs
nicojs approved these changes Oct 26, 2021
Copy link
Contributor

@nicojs nicojs left a comment

Awesome!

@juergba juergba merged commit 3b4cc05 into master Oct 29, 2021
30 checks passed
@juergba juergba deleted the juergba/cross-spawn branch Oct 29, 2021
@juergba juergba added this to the next milestone Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies node.js semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants