WIP: add test for external thread acuiring mutex #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the fix for the busy spin problem has been available in argobots releases for some time now (it was present in 1.1) we should also alter the test logic to fail if CPU utilization is too high now. It was just displaying advisory information previously. |
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 54.18% 54.47% +0.29%
==========================================
Files 65 65
Lines 8826 8910 +84
Branches 1156 1166 +10
==========================================
+ Hits 4782 4854 +72
- Misses 3356 3360 +4
- Partials 688 696 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case to the scheduling unit test that requires an external thread (i.e. a pthread spawned prior to init) to acquire an argobots mutex as well to check CPU usage.
Something isn't right, though. Both the Argobots ULT and the pthread appear to consume CPU time. The former at least should have been corrected in pmodels/argobots#361.
Need to determine if this is a test program error or an Argobots regression. Should also add test cases for eventuals in addition to mutexes, if nothing else for a control case as those definitely are known not to busy spin.
@chuckcranor