Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable max stored qos > 0 messages #359

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

thedevop
Copy link
Collaborator

Address issue #340.

@thedevop
Copy link
Collaborator Author

This has conflict with PR #360. So please merge PR #360 first, and I will update this accordingly.

@thedevop thedevop marked this pull request as ready for review February 4, 2024 20:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7776561439

  • -2 of 18 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 98.723%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server.go 13 15 86.67%
Totals Coverage Status
Change from base Build 7774464517: -0.03%
Covered Lines: 5566
Relevant Lines: 5638

💛 - Coveralls

@thedevop
Copy link
Collaborator Author

thedevop commented Feb 4, 2024

I have resolved the conflict.

@mochi-co
Copy link
Collaborator

mochi-co commented Feb 5, 2024

Thank you!

@mochi-co mochi-co merged commit e9f7215 into mochi-mqtt:main Feb 5, 2024
3 checks passed
mochi-co pushed a commit that referenced this pull request Mar 18, 2024
* Allow configurable max stored qos > 0 messages

* Only rollback Inflight if QoS > 0

* Only rollback Inflight if QoS > 0

* Minor refactor
mochi-co added a commit that referenced this pull request Mar 18, 2024
* Implement file-based configuration

* Implement file-based configuration

* Replace DefaultServerCapabilities with NewDefaultServerCapabilities() to avoid data race (#360)

Co-authored-by: JB <28275108+mochi-co@users.noreply.github.com>

* Only pass a copy of system.Info to hooks (#365)

* Only pass a copy of system.Info to hooks

* Rename Itoa to Int64toa

---------

Co-authored-by: JB <28275108+mochi-co@users.noreply.github.com>

* Allow configurable max stored qos > 0 messages (#359)

* Allow configurable max stored qos > 0 messages

* Only rollback Inflight if QoS > 0

* Only rollback Inflight if QoS > 0

* Minor refactor

* Update server version

* Implement file-based configuration

* Implement file-based configuration

* update configs with maximum_inflight value

* update docker configuration

* fix tests

---------

Co-authored-by: mochi-co <moumochi@icloud.com>
Co-authored-by: thedevop <60499013+thedevop@users.noreply.github.com>
@thedevop thedevop deleted the issue_340 branch March 28, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants