Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep in sync server.System.Inflight #92

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Keep in sync server.System.Inflight #92

merged 2 commits into from
Aug 17, 2022

Conversation

bkupidura
Copy link
Collaborator

No description provided.

@bkupidura
Copy link
Collaborator Author

I dont like require.Equal(t, s.System.Inflight, int64(-2)) in server/server_test.go - but all inflights was injected to server and not received. So s.System.Inflight is out-of-sync.

I see 3 options here:

  • leave it as -2 which looks strange :)
  • remove this assertion from test
  • set s.System.Inflight to proper value before clear

Any opinion?

@bkupidura bkupidura mentioned this pull request Aug 17, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2874272808

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 97.838%

Totals Coverage Status
Change from base Build 2871167893: 0.004%
Covered Lines: 2761
Relevant Lines: 2822

💛 - Coveralls

Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me!

I think -2 on the tests is just fine as it is very specifically testing subtraction, so it makes technical sense.

@mochi-co mochi-co merged commit ad8bf2a into mochi-mqtt:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants