Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podspec in repo so people can track the bleeding edge with cocoapods #9

Closed
wants to merge 2 commits into from

Conversation

MigrantP
Copy link
Contributor

If the podspec is there then devs can put in their podfile:

pod 'MDAboutController', :git => 'git@github.com:mochidev/MDAboutController.git'

And it will pick up the bleeding edge.

@dimitribouniol
Copy link
Member

Is there anyway to leave this out of the submodule? I wanted it to be as pure as possible, requiring only dragging it to Xcode and saying "Add" for it to work. This is why the MessageUI stuff is all optional, and also why there is no ReadMe (this is all in the Demo repo).

@MigrantP
Copy link
Contributor Author

It's a bit unusual to have it organized into two repositories. Most libs have the demo and readme in the same repo, and classes/resources in a folder or folders so you can use the "drag to xcode" method that way if you like.

@dimitribouniol
Copy link
Member

But then you can't have it work nicely as a stand alone submodule (which is what I do in all my projects)

@MigrantP
Copy link
Contributor Author

Why not? Xcode doesn't care about any files you don't add to the project.

@dimitribouniol
Copy link
Member

True, but then you need to go and delete them after importing.

@MigrantP
Copy link
Contributor Author

Just don't add them in the first place. Add the Classes and Images folders only, or put them into a MDAboutController folder at the top level, then add that one. Not sure what's the problem.

Or just use cocoapods =)

@dimitribouniol
Copy link
Member

Then what's the difference between having the podspec in this repo vs in the cocoa pods repo?

@MigrantP
Copy link
Contributor Author

The podspec in this pull request tracks master, not a specific tag. The podspecs in the cocoapods repo must track a specific tagged version.

You don't have to accept it if you don't want, I can just keep it on my fork for myself. Just thought it might be nice to have.

@dimitribouniol
Copy link
Member

Then I'd rather stick with the tagged version then — it'll keep my OCD in check, and allow me to make smaller changes not "release" worthy (aka API experimentation) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants