Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request]: CLIENT_ID is no longer required for CognitoAuth #64

Closed
mochipon opened this issue Nov 2, 2021 · 1 comment · Fixed by #65
Closed

[Request]: CLIENT_ID is no longer required for CognitoAuth #64

mochipon opened this issue Nov 2, 2021 · 1 comment · Fixed by #65
Labels
enhancement New feature or request

Comments

@mochipon
Copy link
Owner

mochipon commented Nov 2, 2021 •
edited
Loading

Describe the solution you'd like - リクエストの内容

The user is unable to issue a new CLIENT_ID. CLIENT_ID is no longer unique to each user.

To be honest, I personally thought that this was going to be a paid service. So I was very surprised to see this decision.

What's the problem this feature will solve? - 解決したい内容

No response

Additional context - その他

No response
@mochipon mochipon added the enhancement New feature or request label Nov 2, 2021
@mochipon
Copy link
Owner Author

mochipon commented Nov 2, 2021

Still thinking how we should follow this change.

It looks like homebridge-open-sesame is going to fall back to the WebAPI (ref. yasuoza/homebridge-open-sesame#181).

mochipon added a commit that referenced this issue Nov 3, 2021
@mochipon
CLIENT_ID is no longer required for CognitoAuth
a68260b 
fixes #64
@mochipon mochipon mentioned this issue Nov 3, 2021
Merged
@yasuoza yasuoza mentioned this issue Nov 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLIENT_ID is no longer required for CognitoAuth mochipon/pysesame3
1 participant
@mochipon