Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage, correct type hints #29

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Increase test coverage, correct type hints #29

merged 3 commits into from
Jun 30, 2021

Conversation

mochipon
Copy link
Owner

  • Hopefully increase test coverage.
  • Support Python 3.6.
  • Utilize pre-commit more
  • Utilize mypy for static typing: fixed a lot of mistakes and omissions.

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #29 (4a8b03e) into main (7bf62a7) will increase coverage by 1.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   93.88%   95.83%   +1.95%     
==========================================
  Files           8        8              
  Lines         376      384       +8     
==========================================
+ Hits          353      368      +15     
+ Misses         23       16       -7     
Impacted Files Coverage Δ
pysesame3/auth.py 94.23% <100.00%> (+1.92%) ⬆️
pysesame3/cloud.py 100.00% <100.00%> (ø)
pysesame3/device.py 100.00% <100.00%> (ø)
pysesame3/helper.py 100.00% <100.00%> (ø)
pysesame3/history.py 100.00% <100.00%> (ø)
pysesame3/lock.py 84.33% <100.00%> (+6.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf62a7...4a8b03e. Read the comment docs.

@mochipon mochipon merged commit 833b8f4 into main Jun 30, 2021
@mochipon mochipon deleted the fix/typing branch June 30, 2021 00:25
@mochipon mochipon added this to the 0.4 milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant