🐛 💩 allow default values if Jenkins replies with null when it shouldn't

src/action/git.rs

@@ -23,6 +23,14 @@ pub struct Revision {
     /// Branch information
     pub branch: Vec<Branch>,
 }
+impl Default for Revision {
+    fn default() -> Self {
+        Revision {
+            sha1: "".to_string(),
+            branch: vec![],
+        }
+    }
+}
 
 tagged_enum_or_default!(
     /// Information about a build related to a branch
@@ -48,3 +56,11 @@ pub struct BuildsByBranch {
     #[serde(flatten)]
     pub branches: HashMap<String, BranchBuild>,
 }
+
+impl Default for BuildsByBranch {
+    fn default() -> Self {
+        BuildsByBranch {
+            branches: HashMap::new(),
+        }
+    }
+}

src/build.rs

@@ -45,6 +45,11 @@ pub enum BuildStatus {
     /// Aborted build
     Aborted,
 }
+impl Default for BuildStatus {
+    fn default() -> Self {
+        BuildStatus::NotBuilt
+    }
+}
 
 tagged_enum_or_default!(
     /// A `Build` of a `Job`
@@ -279,6 +284,12 @@ pub mod changeset {
         }
     );
 
+    impl Default for ChangeSetList {
+        fn default() -> Self {
+            ChangeSetList::EmptyChangeSet {}
+        }
+    }
+
     tagged_enum_or_default!(
         /// Changes found
         pub enum ChangeSet {

src/helpers/tagged_enum_or_default.rs

@@ -97,9 +97,13 @@ macro_rules! tagged_enum_or_default {
                                     match ::helpers::to_snake_case(&key).as_ref() {
                                         $(stringify!($field) => {
                                             $field = Some(
-                                                ::serde::de::MapAccess::next_value::<$type>(
+                                                ::serde::de::MapAccess::next_value::<Option<$type>>(
                                                     &mut map,
-                                                ).map_err(|err| ::serde::de::Error::custom(
+                                                ).map(|v| if let Some(v) = v {
+                                                    v
+                                                } else {
+                                                    <$type as Default>::default()
+                                                }).map_err(|err| ::serde::de::Error::custom(
                                                     format!("{}.{}", stringify!($field), err)
                                                 ))?
                                             );

src/job.rs

@@ -42,6 +42,11 @@ pub enum BallColor {
     #[serde(rename = "notbuilt_anime")]
     NotBuiltAnime,
 }
+impl Default for BallColor {
+    fn default() -> Self {
+        BallColor::NotBuilt
+    }
+}
 
 /// Short Job that is used in lists and links from other structs
 #[derive(Debug, Deserialize, Clone)]
@@ -411,3 +416,9 @@ tagged_enum_or_default!(
         GitSCM (_class = "hudson.plugins.git.GitSCM") {},
     }
 );
+
+impl Default for SCM {
+    fn default() -> Self {
+        SCM::NullSCM {}
+    }
+}

src/user.rs

@@ -7,3 +7,11 @@ pub struct ShortUser {
     /// Absolute URL to the user profile
     pub absolute_url: String,
 }
+impl Default for ShortUser {
+    fn default() -> Self {
+        ShortUser {
+            full_name: "unknown".to_string(),
+            absolute_url: "".to_string(),
+        }
+    }
+}