Add __toString to array of methods to be removed in pass #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davedevelopment fixed the tests on php8+ if you would be so nice and run the workflow again :) |
|
@davedevelopment any chance we can merge and release this soon? |
|
Or maybe @ghostwriter |
|
@KDederichs sorry for not being around. I'm away for the rest of this week, will be back on Tuesday and will pencil Mockery in for some of my time then. |
jrfnl
added a commit
to jrfnl/mockery
that referenced
this pull request
Apr 12, 2022
Follow up on PR mockery#1162, which introduced a new test which again set a dynamic property.
jrfnl
added a commit
to jrfnl/mockery
that referenced
this pull request
Apr 12, 2022
Follow up on PR mockery#1162, which introduced a new test which again set a dynamic property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1153 by adding __toString to array of methods to be removed in generator pass