Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #850 for PHPUnit 5/6/7 compatibilities #903

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

prisis
Copy link
Contributor

@prisis prisis commented Aug 13, 2018

Thx for the first try @barryvdh

@prisis prisis changed the title Fixes #850 for PHPUnit 5/6/7 compatibilities. Fixes #850 for PHPUnit 5/6/7 compatibilities Aug 13, 2018
@patrickarnold79
Copy link

patrickarnold79 commented Aug 14, 2018

Thanks @prisis, I'm facing the same issues you are addressing here.

@davedevelopment
Copy link
Collaborator

I think this looks ok, are all of the changes necessary for the PHPUnit compatibility or was some of it tidying up?

@prisis
Copy link
Contributor Author

prisis commented Aug 14, 2018

All of them are necessary, phpunit added a validator, so i had to remove some keys

@maks-rafalko
Copy link

when are going to release this @davedevelopment?

@prisis prisis deleted the issue-850 branch September 5, 2018 14:27
@rcwsr
Copy link

rcwsr commented Sep 26, 2018

I still get this error with these dependencies:

        "phpunit/phpunit": "~5.7",
        "mockery/mockery": "dev-master",
PHP Fatal error:  Uncaught Error: Class 'PHPUnit\Util\Blacklist' not found in /.../vendor/mockery/mockery/library/Mockery/Adapter/Phpunit/Legacy/TestListenerTrait.php:88
Stack trace:
#0 /.../vendor/mockery/mockery/library/Mockery/Adapter/Phpunit/Legacy/TestListenerForV5.php(45): Mockery\Adapter\Phpunit\Legacy\TestListenerTrait->startTestSuite()
#1 /.../vendor/phpunit/phpunit/src/Framework/TestResult.php(359): Mockery\Adapter\Phpunit\Legacy\TestListenerForV5->startTestSuite(Object(PHPUnit_Framework_TestSuite))
#2 /.../vendor/phpunit/phpunit/src/Framework/TestSuite.php(666): PHPUnit_Framework_TestResult->startTestSuite(Object(PHPUnit_Framework_TestSuite))
#3 /.../vendor/phpunit/phpunit/src/TextUI/TestRunner.php(517): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult))
#4 /.../vendor/phpunit/phpunit/src/TextUI/Command.php(186): PHPUnit_TextUI_TestRunner->doRun(Object(PHPUnit_Framework_TestSuite), Ar in /.../vendor/mockery/mockery/library/Mockery/Adapter/Phpunit/Legacy/TestListenerTrait.php on line 88
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

@rcwsr
Copy link

rcwsr commented Sep 26, 2018

I think because this class does exist:
\PHPUnit\Framework\TestCase in vendor/phpunit/phpunit/src/ForwardCompatibility/TestCase.php

@prisis
Copy link
Contributor Author

prisis commented Sep 26, 2018

can you show me the phpunit full version, from composer install output?

@prisis
Copy link
Contributor Author

prisis commented Sep 26, 2018

i need to change the if check... i will do it asap

@rcwsr
Copy link

rcwsr commented Sep 26, 2018

"name": "phpunit/phpunit",
"version": "5.7.27",
"version_normalized": "5.7.27.0",
"source": {
    "type": "git",
    "url": "https://github.com/sebastianbergmann/phpunit.git",
    "reference": "b7803aeca3ccb99ad0a506fa80b64cd6a56bbc0c"
},
"name": "mockery/mockery",
"version": "dev-master",
"version_normalized": "9999999-dev",
"source": {
    "type": "git",
    "url": "https://github.com/mockery/mockery.git",
    "reference": "5097491b4cd4e2baf325daac344e80fdcdd4a5ed"
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants