Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitted TestListenerTrait if checks #908

Closed
wants to merge 1 commit into from
Closed

Conversation

prisis
Copy link
Contributor

@prisis prisis commented Sep 26, 2018

@prisis
Copy link
Contributor Author

prisis commented Sep 26, 2018

@rcwsr can you try this?

@rcwsr
Copy link

rcwsr commented Sep 27, 2018

I get this:

PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Mockery\Adapter\Phpunit\Legacy\TestListenerTrait::endTest() must be an instance of PHPUnit\Framework\Test, instance of App\SomeTest given, called in /.../vendor/mockery/mockery/library/Mockery/Adapter/Phpunit/Legacy/TestListenerForV5.php on line 37 and defined in /.../vendor/mockery/mockery/library/Mockery/Adapter/Phpunit/Legacy/TestListenerTrait.php:50

@prisis
Copy link
Contributor Author

prisis commented Sep 27, 2018

can you show me your test?

@GrahamCampbell
Copy link
Contributor

What's the status with this PR?

@davedevelopment
Copy link
Collaborator

@GrahamCampbell ugh, sorry, I left them to discuss and I guess it didn't get anywhere. I think it's no longer needed due to #947, but if I'm honest I haven't got time to be investigating PHPUnit 5.7.* issues 🤷‍♂️

@prisis prisis closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants