Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Лидов–古在 #3113

Merged
merged 8 commits into from
Aug 24, 2021
Merged

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Aug 23, 2021

This test showcases the Лидов–古在 mechanism, and thus fixes #1119.
The relevant elements vary as follows:
butcher_e_i
The eccentricity–inclination exchange is evidenced by the following graph:
butcher_c1
The other conserved quantity (which relates all three elements) is also constant: the argument of the periapsis governs that exchange.
butcher_c2

astronomy/butcher_mercury_orbiter_1119.hpp Outdated Show resolved Hide resolved
astronomy/лидов_古在_test.cpp Outdated Show resolved Hide resolved
astronomy/butcher_mercury_orbiter_1119.hpp Outdated Show resolved Hide resolved
astronomy/лидов_古在_test.cpp Outdated Show resolved Hide resolved
astronomy/лидов_古在_test.cpp Outdated Show resolved Hide resolved
astronomy/лидов_古在_test.cpp Outdated Show resolved Hide resolved
date_time::Date::Ordinal(year, 1)));
LOG(ERROR) << "Flowing to " << t;
auto const status = ephemeris_->FlowWithFixedStep(t, *instance);
if (!status.ok()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a CHECK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we do encounter an erroneous status (the orbiter runs into the ground at the end of 1971).

astronomy/лидов_古在_test.cpp Outdated Show resolved Hide resolved
elements.argument_of_periapsis,
mathematica::ExpressIn(Radian));
}
// The elements e, i, and ω all vary quite a lot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numbers would be easier to interpret if, instead of min and max (or in addition), you looked at the relative error between measure and midpoint. It's like 75% for e and 17% for c₁.

Copy link
Member Author

@eggrobin eggrobin Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think the relative errors are meaningful here.

The point (c₁, c₂) lies within a bounded region within [0, 1] × [-3/5, 2/5] (depicted in [Лид61, p. 29], [LC62, p. 745]).

Relative errors clearly aren’t relevant for the angles, and for the eccentricity the fact that the orbit goes to infinity at e=1, not e=0, should make it clear that the relative error of e is, if anything, the reverse of what we care about.

Copy link
Member

@pleroy pleroy Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you demonstrate that something is constant if you have lots of measurements with noise? By looking at its statistical elements. If you are not happy with a cheesy relative error, please do a proper statistical analysis. (We have tools to do that in testing_utilities\statistics.hpp.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, what we care about is the absolute scale of the variations; they are not really noise, but they are very small compared to the size of the region given in Рис. 1.

@pleroy pleroy added the LGTM label Aug 24, 2021
@eggrobin
Copy link
Member Author

retest this please

@eggrobin eggrobin merged commit 07e8049 into mockingbirdnest:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Лидов–古在 mechanism test
2 participants