Plot trajectories using meshes in scaled space #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Jan 25, 2022
pleroy
reviewed
Jan 25, 2022
|
|
||
| // Do not plot the past when there is a target vessel as it is misleading. | ||
| // TODO(egg): This is the future, not the past! |
There was a problem hiding this comment.
Incomprehensible comment is incomprehensible. If the preceding comment is false, fix it.
There was a problem hiding this comment.
The comment is possibly false, but then the code would be false too. This should to be investigated separately.
| private GLLines.Style target_history_style = GLLines.Style.Faded; | ||
| private UnityEngine.Color target_prediction_colour = XKCDColors.LightMauve; | ||
| private GLLines.Style target_prediction_style = GLLines.Style.Solid; | ||
| // TODO(egg): move all of that to the plotter once the RP2 lines are gone. |
There was a problem hiding this comment.
Now. But let’s deal with that in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as performance is concerned, this means that we no longer need to do projection nor hiding in the plot method; further, by directly setting vertices in an array pre-allocated on the C#, we avoid the costly iteration over the RP2Line.
In extremely noodly cases where plotting would drive the frame rate down to 2 or 3 FPS, this improves the framerate by a factor of 4 or 5.
In addition, this means that the trajectories are hidden behind the actual scaled space bodies, and not behind fictitious spheres; this means that in the surface frame, the impact point will be accurately visible (though it still is not indicated by any sort of marker; the impact marker at underground periapsides is unaffected by this change).
This should help with #3035.