Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Brent's method instead of bisection for computing apsides and nodes #3347

Merged
merged 3 commits into from Apr 22, 2022

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Apr 22, 2022

This improves performance by a few percents. Before:

--------------------------------------------------------------------------
Benchmark                                Time             CPU   Iterations
--------------------------------------------------------------------------
ApsidesBenchmark/ComputeApsides  119451153 ns    115664830 ns          362
ApsidesBenchmark/ComputeNodes     36542126 ns     35692924 ns         1191

after:

--------------------------------------------------------------------------
Benchmark                                Time             CPU   Iterations
--------------------------------------------------------------------------
ApsidesBenchmark/ComputeApsides  113703789 ns    112403921 ns          375
ApsidesBenchmark/ComputeNodes     33949542 ns     33410740 ns         1235

This improvement was discussed in #2913.

@eggrobin eggrobin added the LGTM label Apr 22, 2022
@pleroy pleroy merged commit 08171b5 into mockingbirdnest:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants