Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift the maximum deserialization size to 2 GiB from 512 MiB #3380

Merged
merged 11 commits into from Jun 20, 2022

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jun 20, 2022

This is a stopgap measure for helping users who run into #3375.

This PR also adds code that I wrote while debugging the issue and that might be useful in the future:

  1. Add an operator<< for class DelegatingArrayInputStream to print out the chunk being deserialized.
  2. Add support for scanning a journal without executing it; for large journals, this makes it possible to quick figure out what is at the end of the journal, in particular any unpaired method.
  3. Make some replay error messages more helpful.
  4. Add code to verify the output of the serialization by immediately trying to deserialize it.
  5. Log the serialized size of vessels and the number of chunks emitted for a save.

@eggrobin eggrobin added the LGTM label Jun 20, 2022
@pleroy pleroy merged commit c3bdba1 into mockingbirdnest:master Jun 20, 2022
@pleroy pleroy added this to the Hesse milestone Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants