A close window button. #3384
Merged
A close window button. #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
approved these changes
Jun 22, 2022
| RenderWindowContents(window_id); | ||
| } | ||
|
|
||
| public void DisposeWindow() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the prettiest thing, but it should help with usability when there are lots of windows around.
A potentially confusing quirk is that since closing the main window has the exact same effect as toggling the toolbar button, it closes all windows. It’s not clear that anything else would work well though, since there wouldn’t be an unambiguous interaction to bring it back.
Fix #2295.