Improve TransposeView by exposing operations for sizing and indexing #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
changed the title
eggrobin
reviewed
Mar 9, 2024
numerics/concepts.hpp
Outdated
|
|
||
| template<typename T> | ||
| concept unbounded = requires(T& t) { | ||
| { t.size() } -> std::same_as<int>; |
There was a problem hiding this comment.
I could imagine adding size to the fixed types, just like std::array has a size.
There was a problem hiding this comment.
Hmm, actually they have size, rows and columns. So I don't even need the unbounded concept, which is good because we want to handle fixed and unbounded similarly if possible.
Note that size probably doesn't make much sense for matrices, so I'll remove it ultimately.
eggrobin
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this makes heavy use of concepts, so we'll have to see if Clang is happy with it.
Contributes to #3302.