Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename quantity to make way for an actual quantity concept #3913

Merged
merged 5 commits into from
Mar 23, 2024

Conversation

eggrobin
Copy link
Member

No description provided.

Copy link
Member

@pleroy pleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase convertible_to_quantity is not overly elegant, and is what we have been calling "scalar" in the past. I am a tad worried that it's too much of a mouthful. For instance, it would be unpleasant to have to write:

template<convertible_to_quantity Scalar>
class ...

But let's see how things turn out once we actually have and use quantity

quantities/concepts.hpp Outdated Show resolved Hide resolved
@eggrobin
Copy link
Member Author

it would be unpleasant to have to write:

template<convertible_to_quantity Scalar>
class ...

But let's see how things turn out once we actually have and use quantity

We should never want to write that; our types are templatized on things that are actually quantity (that is, Quantity or double, not convertible_to_quantity, which includes int—and even char or bool…)

@eggrobin eggrobin merged commit ece93a6 into mockingbirdnest:master Mar 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants