-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the polynomial evaluators to be specified at the object level and not at the type level #3918
Conversation
benchmarks/benchmarks.vcxproj
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change (also the .filters).
constexpr PolynomialInMonomialBasis<V, A, PRINCIPIA_MAX(l, r), E> | ||
friend operator-(PolynomialInMonomialBasis<V, A, l, E> const& left, | ||
PolynomialInMonomialBasis<V, A, r, E> const& right); | ||
Evaluator<Value_, Difference<Argument_>, degree_> const* evaluator_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a setter for evaluator_
; we may want to set it on the result of an operator +
, or after applying a mutating operation such as +=
.
The evaluator is passed as a tag object (because constructors have to deduce their template parameters). If omitted, Horner is used for small degrees and Estrin for large degrees.
This is only touching polynomials. The other classes that know about evaluators will be handled in future PRs.
A modest contribution to #1922.