New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in the deserialization of integrators #3940

Merged

pleroy merged 2 commits into mockingbirdnest:master from pleroy:IntegratorExit

Mar 30, 2024

Member

pleroy commented Mar 30, 2024

An SPRK can be viewed as an SRKN, so we need to check for both kinds of ODE at deserialization time.

Also remove base::noreturn, which hid the bug for a year, and use std::abort instead.


          Fix a bug in the deserialization of integrators.

98c5447

eggrobin approved these changes

View reviewed changes

eggrobin added the LGTM label


          Fix compilation errors.

c81c5e1

pleroy merged commit e1543f9 into mockingbirdnest:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment