-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Affine maps #65
Affine maps #65
Conversation
Conflicts: geometry/geometry.vcxproj.filters
Conflicts: geometry/geometry.vcxproj geometry/geometry.vcxproj.filters
Conflicts: geometry/geometry.vcxproj.filters
template<typename, typename> class LinearMap> | ||
class AffineMap { | ||
public: | ||
typedef LinearMap<FromFrame, ToFrame> li ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad indent, extra spaces, name should be camel case and not an abbrev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan to make sure this test typedef would get removed was successful!
Please fix the lint errors too. |
The test gives full coverage. I'll do algebraic tests for all maps later on (#64).