Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run releases on Mockito-kotlin 4 #448

Merged
merged 1 commit into from Oct 12, 2021
Merged

Run releases on Mockito-kotlin 4 #448

merged 1 commit into from Oct 12, 2021

Conversation

TimvdLippe
Copy link
Contributor

Per #447 (comment) the release on the previously published tag 4.0.0 didn't work, as it wasn't matching our release configuration.

@TimvdLippe TimvdLippe merged commit 9208417 into main Oct 12, 2021
@TimvdLippe TimvdLippe deleted the run-tags-on-4 branch October 12, 2021 11:38
@frett
Copy link

frett commented Oct 13, 2021

The release still didn't trigger because 4.x isn't included in the if condition for the deploy job: https://github.com/mockito/mockito-kotlin/blob/main/.github/workflows/ci.yml#L84

@TimvdLippe
Copy link
Contributor Author

@frett mockito-kotlin 4.0.0 is available on Maven Central: https://repo1.maven.org/maven2/org/mockito/kotlin/mockito-kotlin/4.0.0/ published with https://github.com/mockito/mockito-kotlin/runs/3869921344 That's because the 4.0.0 tag was put on a commit on main.

@frett
Copy link

frett commented Oct 13, 2021

I was still using the old maven coordinates (com.nhaarman.mockitokotlin2:mockito-kotlin) which was the reason I couldn't find the 4.0.0 release 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants