Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up, removed dead code, rename job, documentation tidy up #1290

Merged
merged 3 commits into from
Feb 15, 2018

Conversation

mockitoguy
Copy link
Member

  • Removed dead method to simplify the code
  • Renamed iOngoingStubbing -> ongoingStubbing ('i' prefix is a relict of history)
  • Removed duplicated word (thanks to @kant for inspiration in Duplicated word on #66 #1288)

@mockitoguy mockitoguy mentioned this pull request Jan 16, 2018
8 tasks
@codecov-io
Copy link

codecov-io commented Jan 16, 2018

Codecov Report

Merging #1290 into release/2.x will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/2.x    #1290      +/-   ##
=================================================
- Coverage          88.08%   88.07%   -0.01%     
+ Complexity          2321     2320       -1     
=================================================
  Files                284      284              
  Lines               5857     5855       -2     
  Branches             702      702              
=================================================
- Hits                5159     5157       -2     
  Misses               519      519              
  Partials             179      179
Impacted Files Coverage Δ Complexity Δ
...ito/internal/stubbing/InvocationContainerImpl.java 92.85% <ø> (-0.25%) 28 <0> (-1)
...mockito/internal/progress/MockingProgressImpl.java 97.26% <50%> (ø) 29 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc794be...68bb156. Read the comment docs.

@mockitoguy mockitoguy merged commit 38e674b into release/2.x Feb 15, 2018
@TimvdLippe TimvdLippe deleted the sf branch March 24, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants