Support mocking kotlin suspend functions compiled by Kotlin 1.3 (#1500) #1501
Conversation
… by Kotlin 1.3 Coroutines support is not experimental anymore and a type of continuation-parameter is renamed to kotlin.coroutines.Continuation
| testCompile libraries.junit4 | ||
|
|
||
| testCompile "org.jetbrains.kotlin:kotlin-stdlib:1.3.0-rc-57" | ||
| testCompile 'org.jetbrains.kotlinx:kotlinx-coroutines-core:0.26.1-eap13' |
There was a problem hiding this comment.
We are using dependencies.gradle to define our dependencies (https://github.com/mockito/mockito/blob/release/2.x/gradle/dependencies.gradle). Could you use the same format as https://github.com/mockito/mockito/blob/release/2.x/subprojects/kotlinTest/kotlinTest.gradle and add the extra dependency in dependencies.gradle?
There was a problem hiding this comment.
Yes of course, I can.
I haven't done that just to avoid introducing the version used only within a single test module
There was a problem hiding this comment.
Could you resolve this comment? Then I think this is ready for a merge.
subprojects/kotlinReleaseCoroutinesTest/kotlinReleaseCoroutinesTest.gradle
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## release/2.x #1501 +/- ##
=================================================
+ Coverage 88.58% 88.59% +<.01%
- Complexity 2398 2401 +3
=================================================
Files 299 299
Lines 6037 6039 +2
Branches 732 733 +1
=================================================
+ Hits 5348 5350 +2
Misses 510 510
Partials 179 179
Continue to review full report at Codecov.
|
|
@TimvdLippe Could you just also release to MC? Otherwise I will do it tonight. |
|
@raphw Yup doing that right now 😄 |
|
2.23.0 is now being pushed to Maven central. It should show up in the next hour. |
|
@TimvdLippe Cool, thanks! |
|
Mocked suspending function returns null with v3.3.3, and this PR is referenced from this SO thread as a solution. Shall I open a new ticket? |
This is an update for #1032
Coroutines support is not experimental anymore and a type of continuation-parameter is renamed to
kotlin.coroutines.ContinuationThis PR is assumed to fix #1500