-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo parent for MultipleParentsClassLoader #2312
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2312 +/- ##
============================================
+ Coverage 84.61% 84.65% +0.04%
- Complexity 2766 2768 +2
============================================
Files 328 328
Lines 8428 8428
Branches 1011 1011
============================================
+ Hits 7131 7135 +4
Misses 1015 1015
+ Partials 282 278 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! Can we please add a regression test for this scenario? Preferably without introducing any new dependencies. E.g. let's not add GWTMockito as dependency to our test suite, but instead construct a ClassLoader ourselves that would behave as if it was the ClassLoader in GWTMockito.
I spent some time thinking about it and reduced the test case to something understandable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slightly refactored the test code to make it clear which exact classes will be loaded by the child ClassLoader and which are not. I have verified that reverting the change in SubclassBytecodeGenerator makes the test fail again.
Thanks Charles for fixing this!
66998ea inadvertently undid a change from 9bc9be6, which breaks behavior under some classloaders that special-case mockito classes. Use of an explicit parent with
MultipleParentsClassLoader
appears to be discouraged in the documentation also.Followup for #2303