Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Javadoc deeps link to Java 11 #2759

Closed
wants to merge 1 commit into from
Closed

Conversation

TimvdLippe
Copy link
Contributor

We currently use Java 6 to deeplink to the JDK and the URL no longer shows the necessary element-list, which is why it currently fails the build: https://github.com/mockito/mockito/actions/runs/3100073977/jobs/5019939573#step:7:229

We currently use Java 6 to deeplink to the JDK and the URL no longer shows the
necessary element-list, which is why it currently fails the build:
https://github.com/mockito/mockito/actions/runs/3100073977/jobs/5019939573#step:7:229
@marcphilipp
Copy link
Contributor

Why not deep link against JDK 8 since that's the baseline?

@TimvdLippe
Copy link
Contributor Author

@marcphilipp The problem is not the Oracle version of the JDK, but the JDK version that we use for the javadoc tool. https://docs.oracle.com/javase/8/docs/api/element-list is missing as well, but https://docs.oracle.com/javase/8/docs/api/package-list does exist. Therefore, we have to use JDK 11+ for the generation of our Javadoc if we want to fix this issue, as that one is aware of package-list and understands how to use it.

@marcphilipp
Copy link
Contributor

FWIW we have this workaround in the JUnit build:
https://github.com/junit-team/junit5/blob/517bfd56ad8ba8d22609b5055f4bb46a3d38c953/documentation/documentation.gradle.kts#L307-L320

@TimvdLippe
Copy link
Contributor Author

Superseded by #2766

@TimvdLippe TimvdLippe closed this Oct 17, 2022
@TimvdLippe TimvdLippe deleted the TimvdLippe-patch-1 branch October 17, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants