Fixed the behavior of compareTo method of the mock objects #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Name of test that checks whether compareTo return 0 for comparison mock with itself is now more intuitive
|
sure, I see two drifferent ways so I use the same as in file in which I add method |
|
Yeah no problem, we decided that last year that we will use snake case for tests, to enhance readability. However we'd like to upgrade these names per modification, but maybe it could make sens to upgrade the whole test base in a single shot. We really need to publish a contributing wiki, and port the old doc on googlecode here ;) |
Introduce snake case instead of camel case for tests names in ShouldMocksCompareToBeConsistentWithEqualsTest class
bric3
added a commit
that referenced
this pull request
Jan 8, 2014
[#467] Fix return value of compareTo for the same objects
|
Thanks, merged ;) |
mockitoguy
changed the title
mockitoguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://code.google.com/p/mockito/issues/detail?id=467
Fix compareTo behaviour the same objects