Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Simplify getting contributors information #120

Closed
mockitoguy opened this issue May 7, 2017 · 0 comments
Closed

Simplify getting contributors information #120

mockitoguy opened this issue May 7, 2017 · 0 comments

Comments

@mockitoguy
Copy link
Member

Problem

Now we have 2 ways of getting contributors and it adds some complexity to the code. During the build we use both ways of getting contributors information, wrapped in separate Gradle tasks. Let's have one robust service for getting contributors and one Gradle task

Workflow

  1. First, we hit repo/contributors endpoint and get all of the guys (https://developer.github.com/v3/repos/#list-contributors).
  • Let’s use max page size :D
  1. Since we may not get the most recent contributors due to GitHub performance limitations, let’s do another hit for commits (https://developer.github.com/v3/repos/commits/#list-commits-on-a-repository).
  • Let’s limit the commits to last 24hrs, earlier commits should be covered by repo/contributors request
  1. We combine the results

Implementation

  1. Update GitHubAllContributorsFetcher. @mstachniuk, can you take a stab at it at some point? :)
  2. Rework Gradle tasks, eliminate dead code - I'll do it with pleasure! (@szczepiq)
mockitoguy added a commit that referenced this issue May 9, 2017
I need this to construct project contributors easily from recent contributors.
See #120
mockitoguy added a commit that referenced this issue May 9, 2017
No longer considering no. of contributions for equals.
This makes more sense and I need this for #120
mockitoguy added a commit that referenced this issue May 9, 2017
Now it gets the contributors that pushed commits to the repo within the last 24hrs.
For design and motivation, see #120
mockitoguy added a commit that referenced this issue May 9, 2017
mockitoguy added a commit that referenced this issue May 9, 2017
I need this to construct project contributors easily from recent contributors.
See #120
mockitoguy added a commit that referenced this issue May 9, 2017
No longer considering no. of contributions for equals.
This makes more sense and I need this for #120
mockitoguy added a commit that referenced this issue May 9, 2017
Now it gets the contributors that pushed commits to the repo within the last 24hrs.
For design and motivation, see #120
mockitoguy added a commit that referenced this issue May 9, 2017
mockitoguy added a commit that referenced this issue May 11, 2017
I need this to construct project contributors easily from recent contributors.
See #120
mockitoguy added a commit that referenced this issue May 11, 2017
No longer considering no. of contributions for equals.
This makes more sense and I need this for #120
mockitoguy added a commit that referenced this issue May 11, 2017
Now it gets the contributors that pushed commits to the repo within the last 24hrs.
For design and motivation, see #120
mockitoguy added a commit that referenced this issue May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant