Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

PowerMock CR: customisable tag name. #333

Closed
thekingn0thing opened this issue Aug 7, 2017 · 3 comments
Closed

PowerMock CR: customisable tag name. #333

thekingn0thing opened this issue Aug 7, 2017 · 3 comments

Comments

@thekingn0thing
Copy link

It will be nice to have ability to customisable tag name for releases. For example, PowerMock uses another tag naming pattern: powermock-. It is not customisable at the current moment according to comment in powermock/powermock#826

@thekingnothing Starting from the end, at the moment only thing about tag that you can customize is its prefix.

        git.setTagPrefix("v"); //so that tags are "v1.0", "v2.3.4"
@mockitoguy
Copy link
Member

@thekingnothing, thank you for using Shipkit!!!

Can you try the tag prefix as suggested by @wwilk? It seems that the tags in powermock are versions prefixed with "powermock-".

This should do the trick:

shipkit {
  git.tagPrefix = "powermock-"
}

@mockitoguy
Copy link
Member

@wwilk, it seems that in the code we use hardcoded "v" literal in few places, instead of using the tag prefix from configuration.

@mockitoguy
Copy link
Member

After @epeee improvements, I think this one can be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants