This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
More concise release notes #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping :) |
|
Friendly ping 2 :) Try to take review commit-by-commit. It's up to you how much you want to review the impl details. I would recommend to focus on:
I would recommend to defocus on:
Let me know if reviewing this PR is helpful for you to get more understanding about the project. If it isn't (and I will respect that), I will not push for reviews but wait a bit and merge myself :) Thanks guys for working on this project together!!! |
wwilk
approved these changes
May 4, 2017
This new setting is great! Code will be so much cleaner.
New formatter offers much cleaner outlook. However, this breaks 2 features: - we no longer show 'publication repository' - we no longer show contributor links I will address those issues in the next set of changes
Thank you team for adding some nice things (like previous version in version.properties). This allowed us to get rid of lots of code :)
|
Thank you for review! |
This was referenced May 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best to review commit-by-commit!