This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
expose release notes url #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockitoguy
approved these changes
Sep 6, 2017
| * @return a link to the generated release notes file hosted on Github. | ||
| */ | ||
| public String getReleaseNotesUrl(String branch) { | ||
| return getGitHubUrl() + "/" + getGitHubRepository() + "/blob/" + branch + "/" + getProject().relativePath(getReleaseNotesFile()); |
There was a problem hiding this comment.
Nice new property!
Let's push all the implementation to the "UpdateReleaseNotes" class. This way, the public API types have only a reason to change when public API changes!
| @@ -129,6 +129,13 @@ public String getGitHubRepository() { | |||
| } | |||
|
|
|||
| /** | |||
| * @return a link to the generated release notes file hosted on Github. | |||
| */ | |||
| public String getReleaseNotesUrl(String branch) { | |||
There was a problem hiding this comment.
I'm wondering if this is unit testable easily. If so, let's a add a test. String concat is a complexity worth unit testing.
There was a problem hiding this comment.
yes, indeed, we should add a test. I will do so.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to be able to log the release notes url (see ##364).
I already did some local testing: