This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
#493 linkable versions in release notes, formatting changes #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilk
reviewed
Nov 20, 2017
| } | ||
|
|
||
| def "formats header when regular version"() { | ||
| expect: | ||
| DetailedFormatter.header("v0.1.0", new Date(1483500000000), true) == "# v0.1.0 (2017-01-04) - " | ||
| DetailedFormatter.header("v0.1.0", true) == "# v0.1.0" |
There was a problem hiding this comment.
I guess now emphasized version would be "#", and a regular one "####". What do you think @mockitoguy ?
wwilk
reviewed
Nov 20, 2017
| private static String buildHeader(String version, Date date, String prefix, String postfix) { | ||
| return prefix + version + " (" + DateUtil.formatDate(date) + ")" + postfix + " - "; | ||
| private static String buildHeader(String version, String prefix, String postfix) { | ||
| return prefix + version + postfix; |
There was a problem hiding this comment.
Seems that postfix is always "" so it's no longer necessary.
wwilk
reviewed
Nov 20, 2017
| authorsSummaryAppendix(contributions, contributors); | ||
| static String releaseSummary(Date date, String version, ContributionSet contributions, Map<String, Contributor> | ||
| contributors, String vcsCommitsLink, String publicationRepository) { | ||
| return " - " + "(" + DateUtil.formatDate(date) + ") " |
There was a problem hiding this comment.
" - " + "(" can be just " - (".
Also the format is different than the one suggested by the issue submitted. It is:
(2017-11-20) n commits
and should be:
2017-11-20 - n commits
Let's put this date prefix into a private method.
wwilk
suggested changes
Nov 20, 2017
wwilk
approved these changes
Nov 22, 2017
|
Thanks for the contribution! |
|
My pleasure! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed formatting in release notes to have linkable versions.